| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Restructure the pg_upgrade code to use several global structures |
| Date: | 2010-10-20 02:31:26 |
| Message-ID: | 201010200231.o9K2VQb11650@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Itagaki Takahiro wrote:
> On Wed, Oct 20, 2010 at 6:38 AM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > Restructure the pg_upgrade code to use several global structures rather
> > than packing everything into 'ctx' and passing that to every function.
> > -------
> > http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=e13f7e9a711c9117e438516537066bbe61df6455
>
> I see the following warning message:
> ----
> In file included from check.c:10:
> pg_upgrade.h:243: warning: built-in function ?log? declared as non-function
> ----
> gcc (GCC) 4.4.4 20100630 (Red Hat 4.4.4-10)
>
> pg_upgrade.h has a variable 'log'.
> extern Log log;
>
> It might be platform-dependent, but I think we'd better rename it.
Thanks, done.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2010-10-20 02:31:37 | pgsql: Rename pg_upgrade 'log' to 'log_opts', to avoid platform naming |
| Previous Message | Bruce Momjian | 2010-10-20 02:06:08 | pgsql: Further speed up pg_upgrade lookups. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2010-10-20 02:49:10 | Re: ISN patch that applies cleanly with git apply |
| Previous Message | Robert Haas | 2010-10-20 02:13:19 | ECPG regression tests need .gitignore update? |