| From: | Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com> |
|---|---|
| To: | Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, David Fetter <david(at)fetter(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Extensions, this time with a patch |
| Date: | 2010-11-24 13:28:08 |
| Message-ID: | AANLkTi=4Xgo-CNQNuG+Hj-mGjX+B-2jhPen3TrSpcgDE@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 23, 2010 at 18:19, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr> wrote:
> Please find that done in attached v4 of the cfparser patch.
RECOVERY_COMMAND_FILE is opened twice in the patch. The first time
is for checking the existence, and the second time is for parsing.
Instead of the repeat, how about adding FILE* version of parser?
It will be also called from ParseConfigFile() as a sub routine.
bool ParseConfigFd(FILE *fd, const char *config_file, int depth, ...)
BTW, the parser supports "include" and "custom_variable_classes"
not only for postgresql.conf but also for all files. Is it an
intended behavior? I think they are harmless, so we don't have
to change the codes; "include" might be useful even in recovery.conf,
and "custom_variable_classes" will be "unrecognized recovery
parameter" error after all.
--
Itagaki Takahiro
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2010-11-24 13:33:20 | Re: Re: Mailing list archives |
| Previous Message | Dmitriy Igrishin | 2010-11-24 13:26:08 | Re: Suggested "easy" TODO: pg_dump --from-list |