Re: Re: [COMMITTERS] pgsql: Fix blatantly uninitialized variable in recent commit.

On Thu, Feb 17, 2011 at 9:50 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> On Thu, 2011-02-17 at 14:37 +0000, Peter Geoghegan wrote:
>> On 17 February 2011 08:30, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>> > In file included from gram.y:12758:
>> > scan.c: In function ‘yy_try_NUL_trans’:
>> > scan.c:16256: warning: unused variable ‘yyg’
>>
>> Lots of people have reported that one. It's been around since August
>> of last year, if not earlier.
>
> Yeh. I wasn't reporting it as an error, just showing the absence of a
> warning for an uninitialized variable in the case shown.
>
> What I should have said was: please share any tips for improving error
> checking.

On MacOS X and Fedora, I put COPT=-Werror in src/Makefile.custom.
(There's a -Wno-error in the rule that compiles scan.c, so it all
works.) But I can't do that on my Ubuntu machine because of those
stupid warnings about write().

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company