From: | Marti Raudsepp <marti(at)juffo(dot)org> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] Return command tag 'REPLACE X' for CREATE OR REPLACE statements. |
Date: | 2011-01-15 21:25:56 |
Message-ID: | AANLkTi=n9XmGmqo9mbCQQVTcSbgAcSQ8eV5SoMKP=v3-@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Here's an updated patch that reports command status back to
ProcessUtility via 'bool' return value.
I was a bit unsure about using bool return values because it's not
immediately obvious what "true" or "false" refer to, but defining a
new enum seemed like overkill, so I went with bool anyway. Any better
ideas?
The 2nd patch also moves MOVE/FETCH command tag formatting up to
ProcessUtility, hopefully this change is for the better.
Regards,
Marti
Attachment | Content-Type | Size |
---|---|---|
0001-Return-command-tag-REPLACE-X-for-CREATE-OR-REPLACE-s.patch | text/x-patch | 14.4 KB |
0002-Move-MOVE-FETCH-command-tag-formatting-to-ProcessUti.patch | text/x-patch | 2.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2011-01-15 21:28:17 | Re: Spread checkpoint sync |
Previous Message | Andy Colson | 2011-01-15 21:20:38 | plperlu problem with utf8 [REVIEW] |