| From: | Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PGSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, r t <pgsql(at)xzilla(dot)net>, Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, Steve Singer <ssinger(at)ca(dot)afilias(dot)info>, Steve Singer <ssinger_pg(at)sympatico(dot)ca> |
| Subject: | Re: Patch to add a primary key using an existing index |
| Date: | 2011-01-26 13:01:37 |
| Message-ID: | AANLkTi=_W8BToaYvWMjQXcmBP-Sv1V6xWCrD2U0bDevR@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 26, 2011 at 6:14 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com> writes:
> > Attached is the updated patch with doc changes and test cases.
>
> Applied with assorted corrections. Aside from the refactoring I wanted,
> there were various oversights.
>
Looking at the commit, the committed patch resembles the submitted patch by
only about 20% :) .
I agree there were quite serious oversights. Thanks for taking care of
those.
Regards,
--
gurjeet.singh
@ EnterpriseDB - The Enterprise Postgres Company
http://www.EnterpriseDB.com
singh(dot)gurjeet(at){ gmail | yahoo }.com
Twitter/Skype: singh_gurjeet
Mail sent from my BlackLaptop device
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dimitri Fontaine | 2011-01-26 13:27:44 | Re: SSI, simplified |
| Previous Message | Simon Riggs | 2011-01-26 13:01:22 | Re: SSI patch version 14 |