From: | Peter Geoghegan <peter(dot)geoghegan86(at)gmail(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, pgadmin-hackers(at)postgresql(dot)org, Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
Subject: | Re: wxWidgets 2.9 build |
Date: | 2011-01-19 23:59:13 |
Message-ID: | AANLkTi=VQZ6YjwV2zaisadpctiJpxmhRTQTge_0PjOqv@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On 19 January 2011 22:40, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>> I have attached a patch for your information. Obviously, I am not
>> asking you to commit it. Most warnings have been fixed - I didn't fix
>> one in gqbGridPanel::OnButtonUp(wxCommandEvent&) where I think we
>> downcast with a C style cast.
>
> Hmm, I didn't spot anything in there that looked horrendously
> objectional. The "foo.c_str()" -> "(const char *) foo" changes are
> somewhat ugly though
I agree, but that's the best we can do while targeting both 2.8 and
2.9. There's a similar situation with switch statements having to be
cast to integer types - when we stop supporting 2.8, we can remove the
casts and call GetValue() on the proxy object.
--
Regards,
Peter Geoghegan
From | Date | Subject | |
---|---|---|---|
Next Message | Guillaume Lelarge | 2011-01-20 07:36:22 | pgAdmin III commit: Disable all widgets in the server dialog... |
Previous Message | Dave Page | 2011-01-19 22:40:41 | Re: wxWidgets 2.9 build |