| From: | Grzegorz Jaskiewicz <gj(at)pointblue(dot)com(dot)pl> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Greg Stark <gsstark(at)mit(dot)edu>, pgsql-hackers Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: clang's static checker report. |
| Date: | 2009-08-23 19:34:27 |
| Message-ID: | A48ED43A-05FC-419F-9EBC-4DB48EC55267@pointblue.com.pl |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 23 Aug 2009, at 20:31, Tom Lane wrote:
> Grzegorz Jaskiewicz <gj(at)pointblue(dot)com(dot)pl> writes:
>> for the record, here's patch that marks elog, etc as dead ends:
>
> That does not look like the right thing at all, since now the checker
> will believe that elog(NOTICE) and such don't return. I think you
> need to use Martijn's suggestion instead.
>
Still, there are few worrying finds on that list as it is anyway.
I hope you guys will find it useful.
I'll modify macro according to Martijn's suggesion, and rerun it again.
My laptop is pretty slow, so it will be probably another 1-1.5h before
I'll get it.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Grzegorz Jaskiewicz | 2009-08-23 22:16:59 | Re: clang's static checker report. |
| Previous Message | Tom Lane | 2009-08-23 19:31:43 | Re: clang's static checker report. |