Re: Minor changes to Recovery related code

From: Jim Nasby <decibel(at)decibel(dot)org>
To: Florian G(dot) Pflug <fgp(at)phlo(dot)org>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Minor changes to Recovery related code
Date: 2007-04-13 00:58:03
Message-ID: A2AAD09F-B22D-40F7-9F6A-C15447FF4A91@decibel.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

On Mar 30, 2007, at 5:51 PM, Florian G. Pflug wrote:
> In realitly, however, I feare that most people will just create a
> script
> that does 'echo "select pg_stop_backup | psql"' or something similar.
> If they're a bit more carefull, they will enable ON_ERROR_STOP, and
> check
> the return value of pgsql. I believe that those are the people who
> would
> really benefit from a pg_stop_backup() that waits for archiving to
> complete.
> But they probably won't check for WARNINGs.
>
> Maybe doing it the other way round would be an option?
> pg_stop_backup() could wait for the archiver to complete forever, but
> spit out a warning every 60 seconds or so "WARNING: Still waiting
> for wal archiving of wal ??? to complete". If someone really wants
> a 60-second timeout, he can just use statement_timeout.

I agree; people are far more likely to take the lazy way out, so it'd
be good to protect against that. Esp. since statement_timeout
provides a means to get the other behavior.
--
Jim Nasby jim(at)nasby(dot)net
EnterpriseDB http://enterprisedb.com 512.569.9461 (cell)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-04-13 02:40:14 Re: Strangely Variable Query Performance
Previous Message Joshua D. Drake 2007-04-13 00:39:31 Re: What tools do people use to hack on PostgreSQL?

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-04-13 02:40:14 Re: Strangely Variable Query Performance
Previous Message Steve 2007-04-13 00:34:18 Re: Strangely Variable Query Performance