| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: removing unnecessary get_att*() lsyscache functions |
| Date: | 2018-10-22 17:12:28 |
| Message-ID: | 9d140f47-1339-00cd-0bc2-3e4418c37253@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 19/10/2018 16:00, Michael Paquier wrote:
>> - if (get_attidentity(RelationGetRelid(rel), attnum))
>> + if (TupleDescAttr(RelationGetDescr(rel), attnum - 1)->attidentity)
> I find this style heavy, saving Form_pg_attribute into a different
> variable would be more readable in my opinion..
OK, slightly reworked version attached.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Remove-get_atttypmod.patch | text/plain | 2.4 KB |
| v2-0002-Remove-get_attidentity.patch | text/plain | 5.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-10-22 17:19:07 | Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line |
| Previous Message | Alexey Kondratov | 2018-10-22 15:51:27 | Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line |