| From: | Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | "robertmhaas(at)gmail(dot)com" <robertmhaas(at)gmail(dot)com>, "sfrost(at)snowman(dot)net" <sfrost(at)snowman(dot)net> |
| Subject: | Re: nodes/*funcs.c inconsistencies |
| Date: | 2015-08-03 01:32:10 |
| Message-ID: | 9A28C8860F777E439AA12E8AEA7694F801121CE2@BPXM15GP.gisp.nec.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Mon, Apr 16, 2012 at 06:25:15AM -0400, Noah Misch wrote:
> > I observed these inconsistencies in node support functions:
>
> A fresh audit found the attached problems new in 9.5[1]. Most are cosmetic
> INT/UINT or field order corrections. The non-cosmetic changes involve
> CustomPath, CustomScan, and CreatePolicyStmt. Feature committers, if the
> existing treatments (ignore custom_plans/custom_paths fields; copy/compare
> "cmd" string pointer as a scalar) were deliberate, please let me know.
>
Thanks for your works.
I also noticed one other inconsistent point; _outMergeJoin() dumps
mergeNullsFirst[] array but it does not use booltostr() macro.
Best regards,
--
NEC Business Creation Division / PG-Strom Project
KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2015-08-03 01:56:53 | Re: Explanation for intermittent buildfarm pg_upgradecheck failures |
| Previous Message | Andreas Karlsson | 2015-08-03 00:35:14 | Re: patch : Allow toast tables to be moved to a different tablespace |