| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: hiding variable-length fields from Form_pg_* structs |
| Date: | 2012-01-09 19:04:59 |
| Message-ID: | 993.1326135899@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> So I think the relcache.c thing should be fixed and then this might be
> good to go.
Cosmetic gripes: I think we could get rid of the various comments that
say things like "variable length fields start here", since the #ifdef
CATALOG_VARLEN lines now represent that in a standardized fashion.
Possibly those lines should be
#ifdef CATALOG_VARLEN /* variable-length fields start here */
to be even clearer.
What would be appropriate to add instead of those inconsistently-used
comments is explicit comments about the exception cases such as
proargtypes, to make it clear that the placement of the #ifdef
CATALOG_VARLEN is intentional and not a bug in those cases.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh Berkus | 2012-01-09 19:05:40 | Re: Why is CF 2011-11 still listed as "In Progress"? |
| Previous Message | Peter Eisentraut | 2012-01-09 18:47:35 | Re: hiding variable-length fields from Form_pg_* structs |