Re: USE_LIBXSLT in MSVC builds

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, dpage <dpage(at)postgresql(dot)org>
Subject: Re: USE_LIBXSLT in MSVC builds
Date: 2010-03-03 08:36:47
Message-ID: 9837222c1003030036y7360545ft35e6bce7e630eb96@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2010/3/3 Andrew Dunstan <andrew(at)dunslane(dot)net>:
>
>
> Tom Lane wrote:
>>
>> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>>
>>>
>>> Baiji is now failing, however. Perhaps it is not finding the XSLT lib or dll?
>>>
>>
>> Curious indeed, because it passed yesterday, *after* I had made all
>> those changes in contrib/xml2 itself.  The only deltas since then are
>> your MSVC script additions.  Now presumably, the XSLT support was
>> commented out in yesterday's run for lack of USE_LIBXSLT, and the "pass"
>> was against the variant output file that allowed for that to fail.
>> So I think you're right that there's something wrong with the link
>> to libxslt, but how come no sign of trouble in the build log?  Does
>> Windows have an equivalent of "rpath" that maybe we're forgetting to
>> add libxslt to?
>>
>>
>>
>
> There is something funny about the iconv setup (libxml requires iconv). My paths on red_bat are a bit different from baiji's so it might not expose the problem. I'm going to make the iconv setup work like the other libraries, and hope it fixes baiji's problem.

Yeah, there are some weird cross dependencies along that. The MSVC
build system really expects you to have libxml+libxslt+iconv all
installed to really get any of them to work. I originally had them all
work the same, but that didn't work, so I just put that in place -
blame being lazy for that. It may well be that it works now due to
other changes around the build system, but originally that hack was
required to make it build at all with XML. But it's good news if it's
not needed anymore and they can all work the same :-)

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Boszormenyi Zoltan 2010-03-03 08:42:14 Re: renameatt() can rename attribute of index, sequence, ...
Previous Message Albe Laurenz 2010-03-03 08:11:00 Re: [GENERAL] to_timestamp() and quarters