Re: Streaming Replication on win32

2010/2/16 Fujii Masao <masao(dot)fujii(at)gmail(dot)com>:
> On Tue, Feb 16, 2010 at 1:33 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> 2010/2/15 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
>>> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>>>> I changed your patch to this, because I find it a lot simpler. The
>>>> change is in the checking in pgwin32_recv - there is no need to ever
>>>> call waitforsinglesocket, we can just exit out early.
>
> Thanks a lot, Magnus!
>
>>>> Do you see any issue with that?
>>>
>>> This definitely looks cleaner, but is there a reason not to use bool
>>> instead of int here?
>>
>> No.
>
> Can include/port/win32.h refer to bool type?

Nope, you're correct, it can't.

Committed without that.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/