Skip site navigation (1) Skip section navigation (2)

Re: Git out of sync vs. CVS

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Git out of sync vs. CVS
Date: 2010-01-17 21:53:47
Message-ID: 9837222c1001171353u7a654729k230e2286f84379e4@mail.gmail.com (view raw or flat)
Thread:
Lists: pgsql-hackers
2010/1/17 Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> 2010/1/17 Peter Eisentraut <peter_e(at)gmx(dot)net>:
>>> Maybe I'm hallucinating and someone could check this in their
>>> environment, but it appears to me that the Git repository is missing
>>> parts of two non-recent commits.  See attached patch.
>
>> Not having looked at the repo in detail, but I bet this happened
>> because the git mirror grabbed it's snapshot in the middle of a cvs
>> commit with multiple files. Since cvs doesn't have atomic commits, I
>> think that kind of thing can happen.
>
> That would explain a single CVS commit appearing as two separate commits
> in the git history; but it hardly seems like an acceptable excuse for
> missing changes altogether, which is what I think Peter said he saw.

It's likely the combination of that, and the cvs to git sync script
not considering that this can happen. So when it does the second pass
(once it's all been synced) it detects it as a single commit, and
doesn't re-import it.

We've seen this happen before.


-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

pgsql-hackers by date

Next:From: Jeff DavisDate: 2010-01-17 22:03:00
Subject: is this a bug?
Previous:From: Simon RiggsDate: 2010-01-17 21:51:17
Subject: Re: Hot Standby and handling max_standby_delay

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group