From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Greg Smith <greg(at)2ndquadrant(dot)com>, Robert Fleming <fleminra(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: LDAP where DN does not include UID attribute |
Date: | 2009-12-12 21:36:46 |
Message-ID: | 9837222c0912121336t33af7993h37ae9701bc554fc5@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Dec 12, 2009 at 12:24, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> On Sat, Dec 12, 2009 at 02:41, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Sun, Dec 6, 2009 at 11:29 PM, Greg Smith <greg(at)2ndquadrant(dot)com> wrote:
>>> Magnus Hagander wrote:
>>>
>>> On Sun, Nov 29, 2009 at 13:05, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>>>
>>>
>>> I'll be happy to work on this to get it ready for commit, or do you
>>> want to do the updates?
>>>
>>>
>>> Here's a patch with my work so far. Major points missing is the
>>> sanitizing of the username and the docs.
>>>
>>>
>>> It looks like you did an initial review here already. Since we haven't
>>> heard from Robert in a while and you seem interested in the patch, I just
>>> updated this one to list you as the committer and marked it "ready for
>>> committer". You can commit it or bounce it from there, but it's obvious
>>> none of our other reviewers are going to be able to do anything with it.
>>
>> I think we should mark this returned with feedback, since it sounds
>> like there are still open items.
>
> I plan to clean up those open item smyself since there has been no
> further feedback from the OP. Hopefully in time before the CF ends. So
> please leave it for a few days more :-)
I have applied the attached, rather heavily reworked, patch. It also
includes the required documentation.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
Attachment | Content-Type | Size |
---|---|---|
ldap.patch | application/octet-stream | 19.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2009-12-12 21:44:17 | Re: XML schemas and PG column names |
Previous Message | Heikki Linnakangas | 2009-12-12 20:42:25 | Re: Streaming replication and non-blocking I/O |