Re: Add cassert-only checks against unlocked use of relations

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, Kevin Grittner <kgrittn(at)ymail(dot)com>
Subject: Re: Add cassert-only checks against unlocked use of relations
Date: 2013-11-05 22:19:21
Message-ID: 970.1383689961@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On that note, any chance you remember why you increased MAX_LOCKMODE by
> 2 to 10 back in 2001 although AccessExclusiveLock is 8? The relevant
> commit is 4fe42dfbc3bafa0ea615239d716a6b37d67da253 .

Probably because it seemed like a round number, which 9 wasn't ...
keep in mind that this data structure is nominally intended to support
other lock semantics besides what LockConflicts[] defines. (BTW,
it's a conceptual error to imagine that the numerical values of the
lock mode codes define a strict "strength" ordering, which is another
reason I don't care for your patch.)

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-11-05 22:23:49 Re: Window functions can be created with defaults, but they don't work
Previous Message Peter Eisentraut 2013-11-05 22:15:45 Re: UTF8 national character data type support WIP patch and list of open issues.