| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Florian Helmberger" <f(dot)helmberger(at)uptime(dot)at> |
| Cc: | "Christopher Kings-Lynne" <chriskl(at)familyhealth(dot)com(dot)au>, "Hackers" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCHES] Changes in /contrib/fulltextindex |
| Date: | 2002-07-01 14:05:56 |
| Message-ID: | 9648.1025532356@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
"Florian Helmberger" <f(dot)helmberger(at)uptime(dot)at> writes:
> Just tried your example - you're right of course! I will remove the hard
> coded delimited list and replace it with the proper calls as shown in the
> code you've sent.
Well, that was a quick hack not clean code. Coding rules for stuff
inside the backend are
- don't do setlocale; it's already been done.
- explicitly cast the argument of any ctype.h macro to
(unsigned char).
Without the latter you have portability problems depending on whether
chars are signed or unsigned.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2002-07-01 14:11:50 | Re: [PATCHES] Changes in /contrib/fulltextindex |
| Previous Message | Florian Helmberger | 2002-07-01 13:56:29 | Re: [PATCHES] Changes in /contrib/fulltextindex |