| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Joe Conway <mail(at)joeconway(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Incautious handling of overlength identifiers |
| Date: | 2016-12-26 19:07:30 |
| Message-ID: | 9597.1482779250@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> I also admit it didn't occur to me to test the function(s) against
> overlength input when developing it. I wouldn't object to adding code
> to deal with overlength identifies, but I'm not really sure I would
> choose truncation over reporting an error. But whatever it'd be, it'd
> be at that level, not at the lower (hash function) level.
Yeah, I'm now convinced that whatever we do about this, if we do anything,
needs to be at a higher code level. It's not hashname()'s job to prevent
use of overlength names. I'll go remove the Assert.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-12-26 20:36:39 | Re: pg_stat_activity.waiting_start |
| Previous Message | Tom Lane | 2016-12-26 19:04:22 | Re: propose to pushdown qual into EXCEPT |