Re: [COMMITTERS] pgsql: Add PF_PRINTF_ATTRIBUTE to on_exit_msg_fmt.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
Cc: Kevin Grittner <kgrittn(at)ymail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Add PF_PRINTF_ATTRIBUTE to on_exit_msg_fmt.
Date: 2013-03-27 13:28:05
Message-ID: 9564.1364390885@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> writes:
>> Alvaro Herrera<alvherre(at)2ndquadrant(dot)com> wrote:
>>> Not happy with misc.c as a filename.

> There's a bunch of files called pg_backup_*.c that are also shared
> between pg_dump and pg_restore, so perhaps pg_backup_utils.c?

Works for me. There's inherently not going to be a lot of content
in this filename, so we aren't going to get anything particularly
memorable (though I agree with the duplicativeness argument against
"misc.c").

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2013-03-27 13:40:49 Re: [COMMITTERS] pgsql: Allow external recovery_config_directory
Previous Message Robert Haas 2013-03-27 13:21:33 Re: [COMMITTERS] pgsql: Allow external recovery_config_directory

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2013-03-27 13:40:49 Re: [COMMITTERS] pgsql: Allow external recovery_config_directory
Previous Message Dean Rasheed 2013-03-27 13:21:49 Re: [PATCH] Exorcise "zero-dimensional" arrays (Was: Re: Should array_length() Return NULL)