Skip site navigation (1) Skip section navigation (2)

Re: pgstattuple locking fix

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Heikki Linnakangas" <heikki(at)enterprisedb(dot)com>
Cc: "ITAGAKI Takahiro" <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-patches(at)postgresql(dot)org
Subject: Re: pgstattuple locking fix
Date: 2007-10-22 17:21:04
Message-ID: 9494.1193073664@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
"Heikki Linnakangas" <heikki(at)enterprisedb(dot)com> writes:
> ITAGAKI Takahiro wrote:
>> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> I'm thinking that having a pin on the buffer should be enough to
>>> call PageGetHeapFreeSpace.
>> 
>> Hmm... we might use pd_upper and pd_lower at different times,

> No I think the original patch was right. You can indeed read
> inconsistent values for pd_upper and pd_lower, though the window is very
> small.

Good point.  I'll apply the original patch and also Heikki's suggested
comment.

			regards, tom lane

In response to

pgsql-patches by date

Next:From: Tom LaneDate: 2007-10-22 17:32:06
Subject: Re: pgstattuple locking fix
Previous:From: Bruce MomjianDate: 2007-10-22 15:09:14
Subject: Re: EXECUTE USING for plpgsql (for 8.4)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group