Re: BUG: pgScript NOT thread safe!!

On Fri, Jun 26, 2009 at 5:50 AM, Ashesh
Vashi<ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:

> That's really weird.
> I tried that patch on windows and found that - the behavior of wxMutex is
> not as expected. :(
>
> On Gtk (Ubuntu 9.04 32bit), the message-box does not adjust to the length of
> the title message.
> (Please find the attached screen-shot.)
>
> Please find the updated patch, it is working on gtk & windows both.
> Though it has not been tested on Osx, but I think - it should work.

Per IM discussion, I've removed the mutex altogether. This code all
gets called in the primary UI thread, so there's actually no
concurrency issue until the script actually starts, thus we can
protect it with a simple static bool.

I suspect this is why the mutex didn't behave as expected - it's
intended to keep different threads out of the protected area.

Tests OK on OSX.

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com