Re: contrib/fixchar (Was: Large databases, performance)

Giles Lean <giles(at)nemeton(dot)com(dot)au> writes:
> Portable code uses 'unsigned char' when using ctype.h features, even
> though for many platforms where 'char' is an unsigned type it's not
> necessary for correct functioning.

Yup. Awhile back I went through the PG sources and made sure we
explicitly casted the arguments of ctype.h functions to "unsigned char"
if they weren't already. If anyone sees a place I missed (or that
snuck in later) please speak up!

> I don't see any isspace() or similar in the code though, so I'm not
> sure why this issue is being raised?

Ditto, I saw no ctype.h usage in Manfred's code. It matters not whether
you label strcmp's argument as unsigned...

regards, tom lane