Re: Assert Levels

From: Greg Stark <greg(dot)stark(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Simon Riggs <simon(at)2ndQuadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Assert Levels
Date: 2008-09-19 19:29:27
Message-ID: 91D0BC0B-0B0D-442E-9279-8B86D7EFFF53@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

greg

On 19 Sep 2008, at 20:13, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> Greg Stark <greg(dot)stark(at)enterprisedb(dot)com> writes:
>> You'll also have to do enough empirical tests to convince people that
>> a --enable-cheap-casserts build really does perform the same as a
>> regular build.
>
> I don't think performance is even the main issue. We have never
> recommended having Asserts on in production because they can decrease
> system-wide reliability. As per the fine manual:

I think Simon's coming at this from a different angle - at least this
is what I took out of his suggestion: there Might be bugs or "can't
happen" events that can happen but only under heavy load. Currently
anyone running heavy workloads does it with assertions off so we
aren't testing that case.

There was a case of this that the HOT thesting turned up. There was a
"can't happen" assertion failure related to hint bits being lost that
was happening.

This is a good example of why running with assertions enabled on
production might not be a good idea. But it's also a good example of
why we should do our performance testing with assertions enabled if we
can do it without invalidating the results.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Sabino Mullane 2008-09-19 19:37:51 Re: Do we really need a 7.4.22 release now?
Previous Message Tom Lane 2008-09-19 19:13:18 Re: Assert Levels