From: | Jorge Gustavo Rocha <jgr(at)geomaster(dot)pt> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | pgsql-bugs(at)lists(dot)postgresql(dot)org |
Subject: | Re: BUG #15827: Unable to connect on Windows using pg_services.conf using Python psycopg2 |
Date: | 2019-07-25 16:43:47 |
Message-ID: | 8cc8fcd9-5748-e55f-1688-b1a02172d3ef@geomaster.pt |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
Hi Tom,
Thank you!
Best regards,
Jorge
Às 17:13 de 25/07/19, Tom Lane escreveu:
> I wrote:
>> Michael Paquier <michael(at)paquier(dot)xyz> writes:
>>> I really think that
>>> we should stick with the approach of only removing \r when it is
>>> followed by \n as we basically want to be able to counter the text
>>> mode of Windows when something external wrote files read by our code,
>>> where \n has been magically transformed to \r\n.
>> As I said, I'm not convinced that filtering \r only where it's actually
>> adjacent to \n is sufficient, even on Windows. To suppose that it is
>> sufficient, you'd have to assume that fgets() guarantees not to split
>> the \r and \n across buffer boundaries, which I doubt that it does.
>> (If it does do that, it would break some other assumptions we have about
>> whether the buffer gets filled completely.)
> Hearing nothing further on this, I went ahead with the patch as I had it
> on HEAD, and a tweaked version of your patch on the back branches.
>
> regards, tom lane
--
Logo* Geomaster, LDA*
*VENHA DESCOBRIR O CAMINHO DO OPEN SOURCE CONNOSC**O
*
Avenida Barros e Soares
N.º 423, 4715-214 Braga
VAT/NIF510 906 109
Phone +351 253 680 323
Site geomaster.pt <http://geomaster.pt>
GPS 41.53322, -8.41929
------------------------------------------------------------------------
Jorge Gustavo Rocha
CTO
Mobile +351 910 333 888
Email jgr(at)geomaster(dot)pt
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2019-07-25 18:27:02 | Re: Logging corruption error codes |
Previous Message | David G. Johnston | 2019-07-25 16:43:22 | Re: BUG #15924: Query Execution and variable declaration |