Re: cleanup execTuples.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: cleanup execTuples.c
Date: 2003-11-21 04:21:42
Message-ID: 8980.1069388502@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Neil Conway <neilc(at)samurai(dot)com> writes:
>> For ExecTypeFromTLInternal, maybe use ExecTupDescFromTL, which is a
>> more accurate name in the first place

> What's the logic in having ExecTypeFromTL() and ExecCleanTypeFromTL()
> implemented in terms of a function called ExecTupDescFromTL()? i.e. if
> we're going to be renaming functions, wouldn't it make sense to rename
> the public API functions, not the internal static functions?

My point was that you intended to export ExecTypeFromTLInternal in order
to convert the other names to macros, and I didn't want an exported name
like that.

The number of call sites seems small enough that altering the API isn't
out of the question either, if you like that better.

regards, tom lane

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Manfred Koizar 2003-11-21 07:53:51 Re: LISTEN/NOTIFY regression tests
Previous Message Neil Conway 2003-11-21 02:31:20 Re: LISTEN/NOTIFY regression tests