Re: readline/libedit selection

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Kris Jurka <books(at)ejurka(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: readline/libedit selection
Date: 2004-12-02 20:22:43
Message-ID: 887.1102018963@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Kris Jurka <books(at)ejurka(dot)com> writes:
> This recent change to readline/libedit selection isn't quite right.
> http://archives.postgresql.org/pgsql-committers/2004-11/msg00330.php

I found the reason for not linking to libtermcap --- there was an
ancient netbsd-specific hack that wasn't general-purpose enough.
This wouldn't have anything to do with the header-file-not-found though.

regards, tom lane

*** config/programs.m4.orig Tue Nov 30 01:13:02 2004
--- config/programs.m4 Thu Dec 2 14:59:03 2004
***************
*** 87,99 ****
for pgac_lib in "" " -ltermcap" " -lncurses" " -lcurses" ; do
LIBS="${pgac_rllib}${pgac_lib} $pgac_save_LIBS"
AC_TRY_LINK_FUNC([readline], [[
! # NetBSD, OpenBSD, and Irix have a broken linker that does not
! # recognize dependent libraries
! case $host_os in netbsd* | openbsd* | irix*)
! case $pgac_lib in
! *curses*) ;;
! *) pgac_lib=" -lcurses" ;;
! esac
esac

pgac_cv_check_readline="${pgac_rllib}${pgac_lib}"
--- 87,100 ----
for pgac_lib in "" " -ltermcap" " -lncurses" " -lcurses" ; do
LIBS="${pgac_rllib}${pgac_lib} $pgac_save_LIBS"
AC_TRY_LINK_FUNC([readline], [[
! # Older NetBSD, OpenBSD, and Irix have a broken linker that does not
! # recognize dependent libraries; assume curses is needed if we didn't
! # find any dependency.
! case $host_os in
! netbsd* | openbsd* | irix*)
! if test x"$pgac_lib" = x"" ; then
! pgac_lib=" -lcurses"
! fi ;;
esac

pgac_cv_check_readline="${pgac_rllib}${pgac_lib}"

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Chris Green 2004-12-02 20:35:58 Re: [HACKERS] Adding Reply-To: <listname> to Lists configuration ...
Previous Message Marc G. Fournier 2004-12-02 20:11:46 Re: [HACKERS] Adding Reply-To: <listname> to Lists