Re: reading uninitialized buffer

From: Neil Conway <neilc(at)samurai(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: reading uninitialized buffer
Date: 2004-02-02 17:02:07
Message-ID: 87smht76uo.fsf@mailbox.samurai.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> OK, then *This* patch does it the way I think is clearest. Most of it
> is just reindenting.

Okay, I applied this patch, and made a few additional cleanups along
the way (the whole function and a couple other things don't need to be
declared in hba.h, for example). The incremental diff between what I
applied and what Andrew posted is attached.

BTW, I think the proper fix is to rewrite next_token(), which is
rather obfuscated at present. Anyone want to take a shot at this?

-Neil

Attachment Content-Type Size
hba_incremental.patch text/x-patch 3.6 KB

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-02-02 17:21:12 Re: CVS source win32 mingw some comile error
Previous Message Tom Lane 2004-02-02 16:54:12 Re: ANALYZE patch for review