From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | pgsql-patches(at)postgresql(dot)org |
Subject: | Re: reading uninitialized buffer |
Date: | 2004-02-02 17:34:29 |
Message-ID: | 401E8A25.60206@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Neil Conway wrote:
>Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>
>
>>OK, then *This* patch does it the way I think is clearest. Most of it
>>is just reindenting.
>>
>>
>
>Okay, I applied this patch, and made a few additional cleanups along
>the way (the whole function and a couple other things don't need to be
>declared in hba.h, for example). The incremental diff between what I
>applied and what Andrew posted is attached.
>
>BTW, I think the proper fix is to rewrite next_token(), which is
>rather obfuscated at present. Anyone want to take a shot at this?
>
>
the file probably has several candidates for cleanup - parse_hba() not
least among them, but I am trying to do several things during my
involuntary "time off", which I expect to end RSN, so I doubt I can get
to either of these soon.
cheers
andrew
From | Date | Subject | |
---|---|---|---|
Next Message | Joe Conway | 2004-02-02 19:08:05 | Re: pg_generate_sequence and info_schema patch (Was: SE |
Previous Message | Bruce Momjian | 2004-02-02 17:29:15 | Re: C locale sort in src/tools/make_ctags |