Re: Review: B-Tree emulation for GIN

From: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Review: B-Tree emulation for GIN
Date: 2009-03-25 22:17:12
Message-ID: 87iqlxmemv.fsf@news-spur.riddles.org.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>>>>> "Tom" == Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:

Tom> BTW ... while I'm thinking about it: it seems to me to be a
Tom> serious error that the consistent() function isn't given nkeys
Tom> so that it can know the length of the arrays it's being handed.
Tom> I suppose it's possible for it to re-deduce nkeys by examining
Tom> the query datum, but that could be quite expensive; and it's
Tom> certainly error-prone to have to keep extractQuery() and
Tom> consistent() in sync on this.

I ran into exactly this problem in hstore; the omission of nkeys there
is seriously annoying.

--
Andrew (irc:RhodiumToad)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-03-25 22:27:20 Re: Review: B-Tree emulation for GIN
Previous Message Tom Lane 2009-03-25 21:55:06 Re: shut down pgsql-interfaces (was Re: [HACKERS] Function C and INOUT parameters)