| From: | Neil Conway <neilc(at)samurai(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: add "WITH OIDS" to CREATE TABLE AS |
| Date: | 2004-01-07 15:48:21 |
| Message-ID: | 87hdz7pxoa.fsf@mailbox.samurai.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> One thing that is *not* fine is something that I see had snuck past
> me in the previous WITH OIDS patch. It is not okay for gram.y or
> scan.l to be looking at GUC variables --- that creates
> synchronization issues.
Good point (I remember reading gram.y's warning about this, but it
must have slipped my mind...). Attached is a revised patch that
corrects this.
-Neil
| Attachment | Content-Type | Size |
|---|---|---|
| create-table-as-with-oids-7.patch | text/x-patch | 22.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Euler Taveira de Oliveira | 2004-01-07 17:10:29 | update for brazilian portuguese translation |
| Previous Message | Andrew Dunstan | 2004-01-07 13:48:49 | Re: [PATCHES] Function argument names |