| From: | Gilles Darold <gilles(dot)darold(at)dalibo(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com>, "Karl O(dot) Pinc" <kop(at)meme(dot)com> |
| Cc: | Christoph Berg <myon(at)debian(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Shulgin, Oleksandr" <oleksandr(dot)shulgin(at)zalando(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch to implement pg_current_logfile() function |
| Date: | 2016-11-12 13:59:44 |
| Message-ID: | 87e8b68c-f9b5-8327-6c42-12761fa0a1cb@dalibo.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Le 09/11/2016 à 02:51, Robert Haas a écrit :
> On Thu, Nov 3, 2016 at 7:34 PM, Karl O. Pinc <kop(at)meme(dot)com> wrote:
>> To me, the CURRENT_LOG_FILENAME symbol should contain the name
>> of the current log file. It does not. The CURRENT_LOG_FILENAME symbol
>> holds the name of the file which itself contains the name of
>> the log file(s) being written, plus the log file
>> structure of each log file.
> I agree that this is confusing.
>
>> IMO, the name of the log files being written, as well as
>> the type of data structure written into each log file,
>> are meta-information about the logging data. So maybe
>> the right name is LOG_METAINFO_DATAFILE.
> +1 for something like this.
>
Ok, it will be changed it in next patch.
--
Gilles Darold
Consultant PostgreSQL
http://dalibo.com - http://dalibo.org
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2016-11-12 15:07:57 | Re: [PATCH] Logical decoding timeline following take II |
| Previous Message | Andres Freund | 2016-11-12 13:04:08 | Re: Re: [COMMITTERS] pgsql: Change the way that LWLocks for extensions are allocated. |