Re: Abbreviated keys for Numeric

From: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Geoghegan <pg(at)heroku(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Gavin Flower <GavinFlower(at)archidevsys(dot)co(dot)nz>
Subject: Re: Abbreviated keys for Numeric
Date: 2015-04-04 06:11:00
Message-ID: 87d23kv31b.fsf@news-spur.riddles.org.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>>>>> "Tom" == Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:

>> For those following along at home, the failures are on these queries:

>> SELECT 1.1 AS two UNION SELECT 2.2;
>> SELECT 1.1 AS two UNION SELECT 2;
>> SELECT 1 AS two UNION SELECT 2.2;
>> SELECT 1.1 AS three UNION SELECT 2 UNION ALL SELECT 2;

>> In each case, the expected result is with the values in ascending
>> numerical order. In each case, the 1 or 1.1 value which ought to
>> appear before 2 or 2.2 instead appears after it. Strictly speaking,
>> this is not the wrong answer to the query, and could be perhaps
>> explained by the planner choosing a hash aggregate rather than a sort
>> + unique plan. But this patch doesn't change the planner at all, so
>> the plan should be the same as it has always been.

Tom> Yeah. We could add an EXPLAIN to make certain, perhaps, but since
Tom> none of the other critters are failing I doubt this explanation.

This failure in the union.sql test is exactly the one that happens if
you build with --disable-float8-byval, for what that's worth.

Does the windows build perhaps not define USE_FLOAT8_BYVAL? that would
explain the breakage.

--
Andrew (irc:RhodiumToad)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2015-04-04 06:29:50 Re: Compile warnings on OSX 10.10 clang 6.0
Previous Message Pavel Stehule 2015-04-04 05:19:15 Re: Providing catalog view to pg_hba.conf file - Patch submission