From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Andreas Pflug <pgadmin(at)pse-consulting(dot)de> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Prettification versus dump safety |
Date: | 2009-11-20 21:25:39 |
Message-ID: | 8795.1258752339@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Andreas Pflug <pgadmin(at)pse-consulting(dot)de> writes:
> Tom Lane wrote:
>> The easy ways out of this are
>> (1) change pg_dump to not prettify trigger definitions at all, or
>> (2) change pg_get_triggerdef from the submitted patch so that it
>> doesn't reduce parenthesization even in "pretty" mode.
>>
> The pretty option was explicitely never intended for pg_dump use.
Yeah. I went with (1) because it's something we can undo in future
on the pg_dump side. The alternative is to immortalize an arbitrary
deviation of pg_get_triggerdef's pretty-fying behavior compared to
every other ruleutils.c function.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2009-11-20 21:39:17 | Re: Why do OLD and NEW have special internal names? |
Previous Message | Tom Lane | 2009-11-20 20:41:45 | Re: TRIGGER with WHEN clause |