| From: | Gregory Stark <stark(at)enterprisedb(dot)com> |
|---|---|
| To: | "Andrew Dunstan" <andrew(at)dunslane(dot)net> |
| Cc: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Jeff Davis" <pgsql(at)j-davis(dot)com>, "Tatsuo Ishii" <ishii(at)postgresql(dot)org>, <laurenz(dot)albe(at)wien(dot)gv(dot)at>, <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: invalidly encoded strings |
| Date: | 2007-09-18 14:12:35 |
| Message-ID: | 878x74kqp8.fsf@oxford.xeocode.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
"Andrew Dunstan" <andrew(at)dunslane(dot)net> writes:
> Tom Lane wrote:
>
>> No. We have a function overloading system, we should use it.
>>
> In general I agree with you.
>
> What's bothering me here though is that in the two argument forms, if the first
> argument is text the second argument is the destination encoding, but if the
> first argument is a bytea the second argument is the source encoding. That
> strikes me as likely to be quite confusing, and we might alleviate that with
> something like:
>
> text convert_from(bytea, name)
> bytea convert_to(text, name)
>
> But if I'm the only one bothered by it I won't worry.
I tend to agree with you. We should only use overloading when the function is
essentially the same just tweaked as appropriate for the datatype, not when
the meaning is different.
--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-09-18 14:17:59 | Re: Open issues for HOT patch |
| Previous Message | Pavan Deolasee | 2007-09-18 13:59:42 | Re: Open issues for HOT patch |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-09-18 15:22:45 | Re: invalidly encoded strings |
| Previous Message | Andrew Dunstan | 2007-09-18 13:24:02 | Re: invalidly encoded strings |