| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Michael Beattie <mtbeedee(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: FATAL: bogus data in lock file "postmaster.pid": "" |
| Date: | 2012-08-27 20:29:46 |
| Message-ID: | 8764.1346099386@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> I have developed the attached patch to report a zero-length file, as you
> suggested.
DIRECTORY_LOCK_FILE is entirely incorrect there.
Taking a step back, I don't think this message is much better than the
existing behavior of reporting "bogus data". Either way, it's not
obvious to typical users what the problem is or what to do about it.
If we're going to emit a special message I think it should be more user
friendly than this.
Perhaps something like:
FATAL: lock file "foo" is empty
HINT: This may mean that another postmaster was starting at the
same time. If not, remove the lock file and try again.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2012-08-27 20:37:01 | Re: Intermittent regression test failures from index-only plan changes |
| Previous Message | Tom Lane | 2012-08-27 20:23:00 | Re: [GENERAL] Why extract( ... from timestamp ) is not immutable? |