Re: [PATCHES] Proposed patch for sequence-renaming problems

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] Proposed patch for sequence-renaming problems
Date: 2005-10-01 15:57:48
Message-ID: 8762.1128182268@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Hold, I think I see an idea here. We have two cases, those for SERIAL
> and those for manual nextval() in DEFAULT. For SERIAL, we can easily
> map to a nextval(::regclass) call on pg_dump reload. For manual
> nextval, it will appear in the dump as nextval('myseq'::text), and Tom
> is saying that will be late binding.

> I think we can live with SERIAL working fine on reload, and requiring
> users who created a manual default using nextval() to ALTER TABLE
> DROP/SET DEFAULT to remove the ::text marker if they want early binding.

"Removing the ::text marker" isn't going to work, because if we have
both nextval(regclass) and nextval(text) then the latter is going to
capture any cases with an unknown literal.

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim C. Nasby 2005-10-01 15:58:47 Re: effective SELECT from child tables
Previous Message Jim C. Nasby 2005-10-01 15:57:27 Re: effective SELECT from child tables