Re: Better error message for a small problem with WITH RECURSIVE

From: Gregory Stark <stark(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Better error message for a small problem with WITH RECURSIVE
Date: 2008-10-08 05:52:30
Message-ID: 874p3nhbvl.fsf@oxford.xeocode.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:

> What we can do is keep a list of "not yet parsed WITH-names" in ParseState,
> and check through that list when about to fail for relation-not-found, and
> issue a suitable message hinting that maybe you forgot RECURSIVE if we find
> a match.
>
> I would think this is overkill, except I've made the same darn mistake
> one time too many. It seems clear to me that a lot of other people will
> make it too, and if the error message isn't more helpful a lot of time
> will get wasted. Barring loud objections, I'm gonna go change it.

Perhaps it would be sufficient to just check if we're inside a non-recursive
WITH without bothering to check if the name matches?

--
Gregory Stark
EnterpriseDB http://www.enterprisedb.com
Ask me about EnterpriseDB's Slony Replication support!

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Grzegorz Jaskiewicz 2008-10-08 05:54:43 Re: query path, and rules
Previous Message iihero 2008-10-08 05:41:42 Re: About postgresql8.3.3 build in MS VS2005