Re: [patch] build issues on Win32

From: Dag-Erling Smørgrav <des(at)des(dot)no>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [patch] build issues on Win32
Date: 2010-03-10 16:37:55
Message-ID: 86pr3c2kv0.fsf@ds4.des.no
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> Dag-Erling Smørgrav <des(at)des(dot)no> writes:
> > Your users might need to link with both.  I'm working on an
> > application that generates animations (specifically, animated
> > weather forecasts) based on data retrieved from a PostgreSQL
> > database.
> This shows up only with static links of libpq, correct?

Yes.

> But the fix seems wrong. If you are using a static libpq, the library
> should be added whenever you link that library into your client
> application. Not for every single EXE and DLL that postgres produces.

Without this patch, pg_ctl fails to build... and I don't see the logic
of including ws2_32 in LIBS but not secur32. remember that LIBS
directly affects what pg_config reports, so if you don't add secur32 to
LIBS, consumers (applications) don't know that they need it.

DES
--
Dag-Erling Smørgrav - des(at)des(dot)no

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dag-Erling Smørgrav 2010-03-10 16:39:07 Re: [patch] build issues on Win32
Previous Message Tom Lane 2010-03-10 16:17:11 Re: [patch] build issues on Win32