Re: PQfnumber and quoted identifiers

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PQfnumber and quoted identifiers
Date: 2003-10-05 18:26:48
Message-ID: 8636.1065378408@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-interfaces

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Peter Eisentraut wrote:
>> Since this behavior was undocumented and no one had noticed it in the last
>> 10 years, I think we can away with removing it.

> I agree. I would never expect to add quotes to a C string to preserve
> case (outside SQL), and the fact that PQfname doesn't return the string
> in quotes is another inconsistency.

Actually I was planning to quiz you about the history. I can see from
the CVS logs that you installed all the patches that added the
quoting/downcasing behavior. Was there any discussion about it?
I dug through the mail archives and found

http://archives.postgresql.org/pgsql-ports/1997-05/msg00081.php
http://archives.postgresql.org/pgsql-bugs/1997-05/msg00023.php
http://archives.postgresql.org/pgsql-hackers/1997-11/msg00170.php

but I could not find any actual discussion about whether there was a
real bug or whether the complainants should be told to fix their code.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephan Szabo 2003-10-05 18:40:10 Re: Open 7.4 items
Previous Message Tom Lane 2003-10-05 18:03:52 Re: [HACKERS] PQfnumber and quoted identifiers

Browse pgsql-interfaces by date

  From Date Subject
Next Message Bruce Momjian 2003-10-05 19:41:15 Re: PQfnumber and quoted identifiers
Previous Message Tom Lane 2003-10-05 18:03:52 Re: [HACKERS] PQfnumber and quoted identifiers