Re: Compiler warning

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Subject: Re: Compiler warning
Date: 2009-05-21 11:29:51
Message-ID: 8576.1242905391@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> On Thursday 21 May 2009 10:01:59 Heikki Linnakangas wrote:
>> Hmm, the patch looks fine to me. The strings are marked with
>> gettext_noop() in the array, and passed through _() when used in errmsg.

> But his patch changes that to

> errhint("%s", _(wentry->drophint_msg))

> so it ends up being run through gettext twice.

How so ? errhint only passes its first argument through gettext.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2009-05-21 11:44:10 Re: Fast ALTER TABLE ... ADD COLUMN ... DEFAULT xxx?
Previous Message Sam Mason 2009-05-21 10:10:16 Re: Fast ALTER TABLE ... ADD COLUMN ... DEFAULT xxx?