From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | Dave Page <dpage(at)vale-housing(dot)co(dot)uk>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: Making pgxs builds work with a relocated installation |
Date: | 2005-10-01 15:28:08 |
Message-ID: | 8552.1128180488@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
[ correcting the completely offtopic Subject ]
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Your patch has been added to the PostgreSQL unapplied patches list at:
> http://momjian.postgresql.org/cgi-bin/pgpatches
> It will be applied as soon as one of the PostgreSQL committers reviews
> and approves it.
Before going down that path, I wanted to review the makefiles and see
whether quoting all occurrences of the path variables would be a
workable thing or not. That would be more desirable, if it's not a
maintenance nightmare, because it'd solve the problem everywhere instead
of only for Windows --- and there is a real risk on, say, Darwin.
One idea that comes to mind is to just quote the variables at point of
creation --- that is, write something like
override pkglibdir := "$(pkglibdir)"
in Makefile.global. I haven't tried this to see if it'd work or not ...
any comments? Would single or double quotes be most desirable?
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Jim C. Nasby | 2005-10-01 15:43:34 | Re: On Logging |
Previous Message | Andrew Dunstan | 2005-10-01 15:19:26 | Re: [HACKERS] A Better External Sort? |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2005-10-01 15:55:12 | Re: Proposed patch for sequence-renaming problems |
Previous Message | Bruce Momjian | 2005-10-01 14:38:25 | Re: [HACKERS] Found small issue with OUT params |