| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Christoph Berg <cb(at)df7cb(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: includedir_internal headers are not self-contained |
| Date: | 2014-04-30 22:17:39 |
| Message-ID: | 8501.1398896259@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On 2014-04-28 13:20:47 -0400, Tom Lane wrote:
>> Printing anything other than the relation OID here is irrelevant,
>> misleading, and inconsistent with our practice everywhere else.
> I don't think it's really comparable to the other scenarios. We should
> print the oid, just as relation_open() does, but the filenode is also
> rather helpful here. How about the attached?
Applied along with a bit of other cleanup.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2014-05-01 00:04:18 | Re: Display of timestamp in pg_dump custom format |
| Previous Message | Robert Haas | 2014-04-30 21:58:25 | Re: shm_mq inconsistent behavior of SHM_MQ_DETACHED |