Re: fd.c doesn't remove files on a crash-restart

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: fd.c doesn't remove files on a crash-restart
Date: 2016-03-16 18:05:13
Message-ID: 8367.1458151513@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Joshua D. Drake" <jd(at)commandprompt(dot)com> writes:
> Hello,
> fd.c[1] will remove files from pgsql_tmp on a restart but not a
> crash-restart per this comment:

> /*
> * NOTE: we could, but don't, call this during a post-backend-crash restart
> * cycle. The argument for not doing it is that someone might want to
> examine
> * the temp files for debugging purposes. This does however mean that
> * OpenTemporaryFile had better allow for collision with an existing temp
> * file name.
> */

> I understand that this is designed this way. I think it is a bad idea
> because:

Possible compromise: remove files only in non-Assert builds?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Julien Rouhaud 2016-03-16 18:05:50 Re: Choosing parallel_degree
Previous Message Andres Freund 2016-03-16 18:04:00 Re: fd.c doesn't remove files on a crash-restart