Re: Keywords in pg_hba.conf should be field-specific

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Brendan Jurd <direvus(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Keywords in pg_hba.conf should be field-specific
Date: 2010-10-17 14:19:10
Message-ID: 8221.1287325150@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Brendan Jurd <direvus(at)gmail(dot)com> writes:
> On 17 October 2010 09:59, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Good point. Maybe the correct fix is to remember whether each token was
>> quoted or not, so that keyword detection can be done safely after the
>> initial lexing. I still think that the current method is impossibly
>> ugly ...

> I'm happy to revise the patch on that basis. Any suggestions about
> how to communicate the 'quotedness' of each token? We could make each
> token a struct consisting of the token itself, plus a boolean flag to
> indicate whether it had been quoted. Does that work for you?

Seems reasonable. I had the idea of a parallel list of booleans in the
back of my mind, but a list of structs is probably easier to understand,
and to extend further if necessary.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2010-10-17 14:34:08 Re: WIP: extensible enums
Previous Message Dean Rasheed 2010-10-17 09:30:27 Re: WIP: extensible enums