Re: pg_dump incorrect output in plaintext mode

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump incorrect output in plaintext mode
Date: 2012-08-28 19:59:15
Message-ID: 8051.1346183955@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Magnus Hagander <magnus(at)hagander(dot)net> writes:
> On Tue, Aug 28, 2012 at 6:42 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I don't see anything particularly incorrect about that. The point of
>> the --verbose switch is to track what pg_dump is doing, and if what
>> it's doing involves going through RestoreArchive(), why should we try
>> to hide the fact?

> "restoring data for table 't'" makes you think it's actuall restoring
> things. It's not. That dumping is implemented by calling an internal
> function called RestoreArchive() has to be an implementation detail...
> It certainly confuses users that we say "restoring" when we're not
> doing that...

Well, why don't we just s/restoring/processing/ in the debug message,
and call it good?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2012-08-28 20:25:36 Re: FATAL: bogus data in lock file "postmaster.pid": ""
Previous Message Pavel Stehule 2012-08-28 19:51:00 Re: Audit Logs WAS: temporal support patch