Re: mingw32 floating point diff

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: mingw32 floating point diff
Date: 2019-08-25 07:02:23
Message-ID: 7fa54146-032e-36e3-5027-67d07209f6dd@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2019-08-23 15:50, Tom Lane wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
>> The circle.sql file already has SET extra_float_digits TO 0, and a few
>> other files have other settings with different values. Are we content
>> to use various numbers until it works in each case, or should we try to
>> use some consistency?
>
> The one in rules.sql doesn't count here. Everyplace else seems to be
> using 0, except for the one in geometry.sql, which seems to be perhaps
> unreasonably conservative. Might be worth researching why it's -3.

I can confirm that SET extra_float_digits TO -1 in circle.sql fixes the
original complaint.

I don't understand this stuff enough to be able to provide a good source
code comment or commit message, so I'd appreciate some help or someone
else to proceed with this change.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2019-08-25 08:51:47 pg_upgrade: Error out on too many command-line arguments
Previous Message PG Bug reporting form 2019-08-25 06:11:05 BUG #15977: Inconsistent behavior in chained transactions