Re: contrib like modules in Red Hat problem, Re: A "bug" report for orafce

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Pavel Stehule" <pavel(dot)stehule(at)gmail(dot)com>
Cc: "Pgsql Hackers" <pgsql-hackers(at)postgresql(dot)org>, Devrim GÜNDÜZ <devrim(at)commandprompt(dot)com>
Subject: Re: contrib like modules in Red Hat problem, Re: A "bug" report for orafce
Date: 2008-01-21 16:17:19
Message-ID: 7664.1200932239@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Pavel Stehule" <pavel(dot)stehule(at)gmail(dot)com> writes:
> On 21/01/2008, Devrim GNDZ <devrim(at)commandprompt(dot)com> wrote:
>> Orafce is about to be approved for Fedora, and I need help for one of
>> the review items. Per:
>> https://bugzilla.redhat.com/show_bug.cgi?id=251805#c1

AFAICT, there's nothing wrong with the Makefile. The problem is with
the specfile, which apparently is calling plain "make install".
It should read

%install
rm -rf $RPM_BUILD_ROOT

make DESTDIR=$RPM_BUILD_ROOT install

Devrim: you should be testing specfiles by building as non-root;
you would have caught this yourself.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2008-01-21 16:26:52 Re: contrib like modules in Red Hat problem, Re: A "bug" report for orafce
Previous Message Marko Kreen 2008-01-21 16:16:57 Re: [GENERAL] SHA1 on postgres 8.3