Re: BUG #13687: bug in row_to_json function with '-infinity' timestamp

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Petr Jelinek <petr(at)2ndquadrant(dot)com>
Cc: Степан Перлов <stepanperlov(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: BUG #13687: bug in row_to_json function with '-infinity' timestamp
Date: 2015-10-20 17:28:04
Message-ID: 75961.1445362084@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

I wrote:
> Petr Jelinek <petr(at)2ndquadrant(dot)com> writes:
>> I think the json code does not need to have custom
>> handling of infinity but could just call the EncodeSpecialTimestamp() if
>> it was exported from the timestamp module.

> Meh. We'd have to change its API too, because it is expecting to print
> into a fixed buffer. I think probably easier to just duplicate the check.

But on second thought, that would have the json code knowing more about
timestamps than timestamp_out does, which seems like pretty bad design.
I'll change it as you suggest.

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2015-10-20 18:22:27 Re: BUG #13688: lack of return value in r_mark_regions()
Previous Message Alvaro Herrera 2015-10-20 17:20:51 Re: BUG #13688: lack of return value in r_mark_regions()