Re: [COMMITTERS] pgsql: Simplify the syntax of CREATE/ALTER TEXT SEARCH DICTIONARY by

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Teodor Sigaev <teodor(at)sigaev(dot)ru>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Simplify the syntax of CREATE/ALTER TEXT SEARCH DICTIONARY by
Date: 2007-08-22 14:39:01
Message-ID: 7468.1187793541@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Teodor Sigaev <teodor(at)sigaev(dot)ru> writes:
>> I also made these statements verify that the tmplinit method will accept
>> the new settings before they get stored; in the original coding you didn't
>> find out about mistakes until the dictionary got invoked.

> That is source of initdb error with -E KOI8-R --locale ru_RU.KOI8-R options :
> ERROR: character 0xc3a5 of encoding "UTF8" has no equivalent in "KOI8"

> Snowball dictionary tries to convert swedish (some languages too, but
> that was first which I see) stopword file from UTF8 to KOI8 encoding.

Hmm. That's a problem, but I don't think that not having any error
checking on CREATE TEXT SEARCH DICTIONARY's parameters is a good
solution.

The first kluge that comes to mind is to suppress the error check in a
standalone backend (ie, when not IsUnderPostmaster), which would cover
the initdb case. But maybe there are better answers ... any ideas?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Teodor Sigaev 2007-08-22 16:21:08 Re: [COMMITTERS] pgsql: Simplify the syntax of CREATE/ALTER TEXT SEARCH DICTIONARY by
Previous Message Teodor Sigaev 2007-08-22 12:20:29 Re: pgsql: Simplify the syntax of CREATE/ALTER TEXT SEARCH DICTIONARY by

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-08-22 15:10:44 Naming of the prefab snowball stemmer dictionaries
Previous Message Stefan Kaltenbrunner 2007-08-22 14:34:42 Re: A couple of tsearch loose ends