| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Albert Schabhuetl <albert_schabhuetl(at)yahoo(dot)de> |
| Cc: | PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #15520: PAM authentication + domain socket -> DNS query for symbolic hostname [local] |
| Date: | 2018-11-26 14:02:12 |
| Message-ID: | 72c867be-2e27-fa2c-54e6-7ec26ab5c69b@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 25/11/2018 23:30, Thomas Munro wrote:
>>> I wonder if anyone out there has come to rely on the value "[local]"
>> I vote for changing it, and documenting it in the release notes.
> Yeah. Here is a draft patch to change that. Test output:
>
> $ psql -h localhost postgres munro
> PAM_USER=munro, PAM_RHOST=localhost
> $ psql postgres munro
> PAM_USER=munro, PAM_RHOST=
I think this is the right thing to do.
About your patch, if we're not going to set PAM_RHOST, then we should
also avoid the call to pg_getnameinfo_all() earlier in CheckPAMAuth().
Look at the original patch linked earlier in the thread; we just need to
put if statements around both of those hunks.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PG Bug reporting form | 2018-11-26 14:57:17 | BUG #15522: pg_upgrade from 9.6 to PG 11.1 with postgis 2.4.5 give error undefined symbol geod_polygon_init |
| Previous Message | Feike Steenbergen | 2018-11-26 09:12:36 | Re: New sessions on a database to be dropped consume 100% cpu |